On Oct 24, 2003, at 7:19 PM, Ronnie Sahlberg wrote:
maybe you can add this to the WebPage for the example screenshots
it displays service response time for SMB plotted as MIN/MAX/AVERAGE
starts to look very cool.
It might be useful to extract the graphing code from io_stat.c, so that
other taps could use it. (Eventually, it might be useful to have a
general framework that takes tables, which have:
a list of columns, with types (perhaps using FT_ values) and names;
a list of rows, each of which has column values;
a title (which is either a string, possibly with newlines in it, or a
list of strings that are lines);
and:
in Tethereal, prints them out;
in Ethereal shows them as a column list, or as a graph (with one
column, perhaps always the first, being X, and the others being Y), or
as a pie chart (with one column being the name and the other being the
percentage - this would require a two-column table), or...;
and implement many of the taps atop that. That might allow many taps
to have less code that's Tethereal-specific or Ethereal-specific - the
Tethereal-specific and Ethereal-specific code would control the
presentation of the table, and the UI for setting properties of the
table, but the presentation of the table would be in the common code.
The SMB SRT code would require that to be generalized to support a
*list* of tables.)
Also, if you select "advanced..." in the "Unit:" option menu, you get a
"You did not specify a field name." alert box, because the "Calc:"
section doesn't have a field name when you start out.
Microsoft's Performance Monitor in W2K adds new graphs to the plot with
an "Add" function. They pop up a dialog box to specify the properties,
which are read-only in the main window; there's a button for editing
those properties, which appears to let you edit more properties (e.g.,
it lets you select a color; adding an item appears to pick a new color
for you). I'll have to look at the NT4 version this evening (which is
a bit simpler, as it's not done as an MMC plugin) as well.
If we do the same, we might be able to do that a little bit cleaner.
It also would leave the control area less cluttered if you have fewer
than 5 graphs, and let you draw more than 5 graphs. It'd also let the
"Unit:" and "Y-scale" fields be per-graph (that'd require multiple Y
axes - but Performance Monitor has the same issue; it solves it by as
far as I can tell, ignoring it, and only drawing the Y axis for the
first graph it created). However, if "advanced..." is selected, you
might need multiple Y axes *anyway*, as not all the fields necessarily
have the same units (you might be plotting a time and a byte count, for
example).
That might also make it a bit more obvious how to change the properties
of a graph.
