Ethereal-dev: Re: [Ethereal-dev] New/Update dissectors: IOS 4, BSSAP/BSAP, IS-637 (SMS)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Wed, 22 Oct 2003 14:09:34 -0700

On Oct 22, 2003, at 8:36 AM, Michael Lum wrote:


packet-ansi_a.c
	2nd register function call removed
Checked in, along with the BSSAP/BSAP dissector and the IS-637-A Transport Layer support. 

The BSSAP/BSAP dissector gets the warning
packet-bssap.c:88: warning: `bssap_parameter_values' defined but not used
I don't see anything in the BSSAP/BSAP dissector that fetches a parameter type value from the packet - "dissect_bssap_parameter()" gets passed the parameter type as an argument, and it's called from:
"dissect_bssap_var_parameter()", which also gets the parameter type passed as an argument;
"dissect_bssap_message()", which passes it hardcoded values (presumably because the sequence of parameters is fixed). 

"dissect_bssap_var_parameter()" also gets passed hardcoded values.
If, in fact, the parameter type (DLCI/Length/Data) never appears in the packet data, then there's no use for the "bssap_parameter_values[]" table, and it should be removed.