Ethereal-dev: Re: [Ethereal-dev] Srvloc version 2 update

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Greg Morris" <gmorris@xxxxxxxxxx>
Date: Wed, 01 Oct 2003 15:19:13 -0600
Cool, Thanks...

>>> Guy Harris <guy@xxxxxxxxxxxx> 10/1/2003 3:17:55 PM >>>

On Oct 1, 2003, at 12:49 PM, Greg Morris wrote:

> SRVLOC packets on TCP will not desegment properly. The byte count is
> not at the same offset as is version 1.

No, it is at the same offset - it's just 1 byte longer than in V1, at
least according to RFC 2608.

I've checked in a change to handle that (including fetching the length
with tvb_get_ntoh24() with SLPv2), as well as to pass 5 as the "fixed
length" to "tcp_dissect_pdus()" so that the "get PDU length" routine is
guaranteed to have 5 bytes of data (so it can be certain that, if it's
an SLPv2 packet, all 3 bytes of length are there).