Ethereal-dev: Re: [Ethereal-dev] Patch for rtp_analysis

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Fri, 26 Sep 2003 15:30:23 -0700

On Sep 26, 2003, at 12:45 AM, Lars Ruoff wrote:


good idea to centralize the RTP payload type definitons.
But why not directly in packet-rtp.h?
To keep stuff that would be used by dissectors for RTP payloads, and stuff that'd be needed only by RTP taps, separate.
(packet-rtp.h also declares "rtp_add_address()", but *nothing* in Ethereal uses it and, as far as I can tell, nothing in Ethereal ever used it - should it just be removed?). 


Note that rtp_stream_dlg.h should use the include also, instead of
redefining the PTs


Done.