Wireshark · Ethereal-dev: Re: [Ethereal-dev] [PATCH] WSP parsing of x-wap.tod encoded as text

[Loïc Minier <lool+ethereal@xxxxxxxxxx>]

     Hey,


 Ethereal is not dumping correctly a field in its wsp-dissector. Please
 consider the attached patch against CVS which solves the problem here.
   I attached a small capture exposing the problem.

   Could you please explain me anything which could be wrong with this
 patch?


    Regards,


-- 
Loïc Minier <lool@xxxxxxxx>

Index: packet-wsp.c
===================================================================
RCS file: /cvsroot/ethereal/packet-wsp.c,v
retrieving revision 1.73
diff -u -b -r1.73 packet-wsp.c
--- packet-wsp.c	29 Jul 2003 21:30:32 -0000	1.73
+++ packet-wsp.c	4 Aug 2003 10:40:50 -0000
@@ -2299,7 +2299,12 @@
 	{
 		valueType = get_value_type_len (tvb, offset,
 		    &subvalueLen, &subvalueOffset, &offset);
-		if (get_integer (tvb, subvalueOffset, subvalueLen,
+		if (valueType == VALUE_IS_TEXT_STRING) {
+			proto_tree_add_text (tree, tvb, startOffset,
+			    offset - startOffset, "%s: %s", token,
+			    tvb_get_ptr (tvb, subvalueOffset, subvalueLen));
+		}
+		else if (get_integer (tvb, subvalueOffset, subvalueLen,
 		    valueType, &secs) == 0)
 		{
 			/*

Attachment: xwaptod.bin
Description: Binary data