On Sun, Jul 20, 2003 at 06:41:11PM +0200, Christoph Neusch wrote:
> i wrote a new plugin for the V5.2-User Adaptation Layer Protocol. The files
> attached at the end. It have been tested on Win NT 4.0, 2000, XP and Linux
> Redhat,SuSe. So i hope you have no problems. But if something doesn't work,
> please tell me.
It didn't compile (and also got some warnings, which might be real bugs):
packet-v5ua.c: In function `dissect_dlci_parameter':
packet-v5ua.c:274: warning: `efa' might be used uninitialized in this
function
packet-v5ua.c: In function `dissect_layer3_message':
packet-v5ua.c:1083: warning: comparison is always 1 due to limited range
of data type
packet-v5ua.c:1094: warning: comparison is always 1 due to limited range
of data type
packet-v5ua.c:1101: warning: comparison is always 1 due to limited range
of data type
packet-v5ua.c:1119: warning: comparison is always 1 due to limited range
of data type
packet-v5ua.c:997: warning: `discriminator_offset' might be used
uninitialized in this function
packet-v5ua.c:997: warning: `address_offset' might be used uninitialized
in this function
packet-v5ua.c:997: warning: `low_address_offset' might be used
uninitialized in this function
packet-v5ua.c:997: warning: `msg_type_offset' might be used
uninitialized in this function
packet-v5ua.c:997: warning: `info_element_offset' might be used
uninitialized in this function
packet-v5ua.c: In function `dissect_parameter':
packet-v5ua.c:1519: warning: unused parameter `tree'
packet-v5ua.c:1522: warning: `parameter_item' might be used
uninitialized in this function
packet-v5ua.c:1523: warning: `parameter_tree' might be used
uninitialized in this function
packet-v5ua.c: In function `dissect_v5ua':
packet-v5ua.c:1887: warning: unused variable `total_length'
packet-v5ua.c: In function `proto_register_v5ua':
packet-v5ua.c:2209: `suppression_indication_values' undeclared (first
use this function)
packet-v5ua.c:2209: (Each undeclared identifier is reported only once
packet-v5ua.c:2209: for each function it appears in.)
packet-v5ua.c:2209: initializer element for `hf[49].hfinfo.strings' is
not constant
packet-v5ua.c:2217: `ack_request_indication_values' undeclared (first
use this function)
packet-v5ua.c:2217: initializer element for `hf[51].hfinfo.strings' is
not constant
You should also supply patches for the Makefile.am/Makefile.nmake at the
top level and in the "plugins" subdirectory, and the top-level
configure.in file, to add a new plugin directory.
