Wireshark · Ethereal-dev: Re: [Ethereal-dev] Q.931 Codeset Shift IE not being decoded prope rly

[Tomas Kukosa <tomas.kukosa@xxxxxxxxxxx>]

Hi,
  the next "bug" is that the codeset is ignored during IEs decoding. I
have prepared fix for it but I am a little bit busy now and I will
release it nex week (or one week later).
  Tom

Bryan Pelham wrote:
> 
> I am referring to 0.9.13a.  Looks like this issue may have been resolved in
> revision 1.54 of packet-q931.c.  I'll give the current CVS version a try.
> 
> Bryan
> 
> -----Original Message-----
> From: Martin Regner [mailto:martin.regner@xxxxxxxxx]
> Sent: Wednesday, July 09, 2003 9:14 AM
> To: Bryan Pelham; ethereal-dev@xxxxxxxxxxxx
> Subject: Re: [Ethereal-dev] Q.931 Codeset Shift IE not being decoded
> properly
> 
> Bryan Pelham wrote:
> 
> >I believe the Q.931 codeset Shift Information Element is not being decoded
> >properly by EtherReal.
> 
> There has been some changes regarding Codeset Shift in the Q.931 dissector
> after Ethereal 0.9.13/0.9.13a was released.
> Are you referring to Ethereal 0.9.13/0.9.13a (or earlier) or the current CVS
> version?
> 
> Ethereal 0.9.13 contains revison "1.53" of packet-q931.c. The changes was
> made in revison "1.54" of packet-q931.c
> 
> Revision 1.54 / (colorized) - annotated - [select for diffs] , Tue Jun 24
> 05:58:32 2003 UTC (2 weeks, 1 day ago) by guy
> Branch: MAIN
> Changes since 1.53: +60 -58 lines
> Diff to previous 1.53
> >From Tomas Kukosa:
> 
>  1) Swap locking/non-locking shift IEs. It was used in wrong way. "0"
>     indicates locking  and "1" indicates non-locking shift.
>  2) Return back to last locked codeset instead of codeset 0 after
>     non-locking shift.
>  3) Handling of unknown single-octet IEs.
> 
> ----------------------------------------------------------------------------
> ----
> Revision 1.53 / (colorized) - annotated - [select for diffs] , Mon Apr 14
> 18:04:13 2003 UTC (2 months, 3 weeks ago) by guy
> Branch: MAIN
> CVS Tags: release-0-9-13a, release-0-9-13, release-0-9-12
> Changes since 1.52: +2 -2 lines
> Diff to previous 1.52
> 
> http://www.ethereal.com/cgi-bin/viewcvs.cgi/ethereal/packet-q931.c.diff?r1=1
> .53&r2=1.54
> 
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev

-- 
_________________________________________________

ANF DATA              ANF DATA spol. s r. o.
a SIEMENS Company     M-palác, Heršpická 5
                      639 00 Brno
                      Czech Republic
Tomáš Kukosa          Tel.: +420 - 5 4310 6822
PSE ECT IPN 5         Fax: +420 - 5 4324 8780
Room: 8.24            mailto:tomas.kukosa@xxxxxxxxxxx
_________________________________________________