Ethereal-dev: RE: [Ethereal-dev] packet-smpp.c: Short Message reassembly and de code preferenc

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Biot Olivier <Olivier.Biot@xxxxxxxxxxx>
Date: Mon, 7 Jul 2003 16:42:31 +0200 
> -----Original Message-----
> From: Guy Harris
> 
> On Wednesday, July 2, 2003, at 5:50 AM, Biot Olivier wrote:
> 
> > Attached patch provides Short Message reassembly (see note in code)
> 
> The note says:
> 
> 	If the SMPP connection stays open, then the packet 
> reassembly code will
> 	complain when several concatenated SMS messages share 
> the same message 
> ID.
> 
> Using "fragment_add_seq_check()" should fix that - it distinguishes 
> between in-progress and completed reassemblies, with the former being 
> hashed by the ID and the latter being hashed by the frame number and 
> ID.

Thanks for the hint! Attached patch fixes this. Please check in.

Regards,

Olivier

PS still not clear to me how I can reassemble fragments sent over distinct
SMPP sessions...

Attachment: packet-smpp.c.diff
Description: Binary data