Ethereal-dev: Re: [Ethereal-dev] Dissector for EtherNet/IP

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Wed, 11 Jun 2003 02:03:38 -0700
On Tue, Jun 10, 2003 at 04:59:55PM -0500, Joakim Wiberg wrote:
> I think that just CIP would be ok, at least for people using industrial
> ethernet.
> 
> I have changed the name of the file and all the stuff that's visible (at
> least I think so).

OK, I've checked it in.

> There is still variable names and defines containing
> ENIP, is this something that have to be fixed before this dissector can be
> accepted?

No.

However, here are some warning messages produced when compiling with GCC
2.7.2.3 with the standard -W flags used with Ethereal:

	packet-cip.c: In function `show_cdf':
	packet-cip.c:1209: warning: unused variable `path_tree'
	packet-cip.c: In function `dissect_cipencap':
	packet-cip.c:1831: warning: unused variable `pi'
	packet-cip.c: In function `dissect_enipio':
	packet-cip.c:2021: warning: unused variable `csftree'
	packet-cip.c:2021: warning: unused variable `headertree'
	packet-cip.c:2020: warning: unused variable `csf'
	packet-cip.c:2020: warning: unused variable `encaph'
	packet-cip.c:2017: warning: unused variable `cmd_string'
	packet-cip.c:2016: warning: unused variable `pkt_type_str'
	packet-cip.c:2015: warning: unused variable `encap_cmd'
	packet-cip.c:2015: warning: unused variable `encap_data_length'
	packet-cip.c:2014: warning: unused variable `packet_type'
	packet-cip.c: At top level:
	packet-cip.c:213: warning: `proto_enipio' defined but not used

Should those variables be removed, or is there code that needs to be
written to use them?