The GPL isn't a problem, if we're using something that's GPL'd I think that
we should help improve it we can.
The the dissector is far from supporting all "features" of the protocoll,
but all common parts have been implemented. What I would like, is to get
this dissector into the next release, so if someone interested can start
using it. Are you getting close to a release?
Should I supply a patch as soon as possible so all of you can have a look at
it, and I can make changes according to you're recomendations? I'm not sure
how strict you're are about the coding convention, we have tried to follow
the recomendations.
/Joakim
-----Original Message-----
From: Richard Sharpe [mailto:rsharpe@xxxxxxxxxxxxxxxxx]
Sent: den 3 juni 2003 12:05
To: Joakim Wiberg
Cc: ethereal-dev@xxxxxxxxxxxx
Subject: Re: [Ethereal-dev] New dissector
On Tue, 3 Jun 2003, Joakim Wiberg wrote:
> We have put together a dissector for a protocol called EtherNet/IP. This
is
> a protocol for industrial control over Ethernet, more information can be
> found at http://www.odva.org.
>
> Would it be possible to get this dissector included in Ethereal as a
> "standard" dissector? If so what do I have to do to get it into the
project?
> It was developed aginst the 0.9.12 release and not the CVS tree.
Yes, but note, Ethereal is GPL'd, so the code you provide must be under a
compatible license, which usually means GPL.
If you can post patches between what you have and a pristine 0.9.12 tree,
we can most likely add it for you.
Something like this will generate a patch for us:
diff -uNr my-source-tree ethereal-0.9.12
Hopefully you modified Makefile.am etc, but if not, we can figure it out.
Also, sending us a sample capture file would be good as well.
Thanks for your offer.
Regards
-----
Richard Sharpe, rsharpe[at]ns.aus.com, rsharpe[at]samba.org,
sharpe[at]ethereal.com, http://www.richardsharpe.com