Ethereal-dev: Re: [Ethereal-dev] Tethereal -z io,users,ip has stats in wrong order

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Ronnie Sahlberg" <ronnie_sahlberg@xxxxxxxxxxxxxx>
Date: Mon, 19 May 2003 21:28:21 +1000
thanks for the bug report and the fix.
checked in.

----- Original Message -----
From: "Visser, Martin (Sydney)"
Sent: Monday, May 19, 2003 8:14 PM
Subject: RE: [Ethereal-dev] Tethereal -z io,users,ip has stats in wrong
order


Good one!

Actually, changing it to

if(!memcmp(&iph->ip_dst,iui->addr1,4)){
iui->frames1++;
iui->bytes1+=pinfo->fd->pkt_len;
} else {
iui->frames2++;
iui->bytes2+=pinfo->fd->pkt_len;
}

Would probably align it better aesthetically (and algorithmically) with
the "eth" and"tr" subroutines.


Martin


Martin Visser ,CISSP
Network and Security Consultant
Technology & Infrastructure - Consulting & Integration
HP Services

3 Richardson Place
North Ryde, Sydney NSW 2113, Australia
Phone *: +61-2-9022-1670    Mobile *: +61-411-254-513
   Fax 7: +61-2-9022-1800     E-mail * : martin.visser@xxxxxx