Wireshark · Ethereal-dev: Patch: packet-wtp.c (was RE: [Ethereal-dev] WAP bug(s) found on c oncatenated WTP)

[Biot Olivier <Olivier.Biot@xxxxxxxxxxx>]

Hi all,

Please find a fix to the posted problems in attached small patch.
It is possible that part of this patch already entered packet-wtp.c earlier
(I cannot access viewcvs for now).

Please review and check in.

Regards,

Olivier

> -----Original Message-----
> From: Budiyanto Fritz [mailto:fritzb88@xxxxxxxxx]
> Sent: donderdag 15 mei 2003 21:37
> To: ethereal-dev@xxxxxxxxxxxx
> Cc: fritzb88@xxxxxxxxx
> Subject: [Ethereal-dev] WAP bug(s) found on concatenated WTP
> 
> 
> Hi,
> 
> There are a few bugs on the concat wtp:
> 
> 1. WTP PDU Length can be 7 bit or 15 bit.
> Page 49 of WTP spec version 10 (jul 2001) says
> PDU Length field can be 7 or 15 bits ... (its like
> decoding UINTVAR)
> 
> 2. The highlighting of WSP reply data is incorrect.
> In the source code: 
> ti = proto_tree_add_item (wsp_tree,
> hf_wsp_reply_data,tvb,offset,-1,bo_little_endian);
> 
> because of -1, it highlight the entire frame, and it
> does not work with concatenated WTP. ie. for the first
> WTP, the reply data portion is highlighted until the
> end of the packet (highlight includes the rest of
> concat WTP)
> 
> I am hoping that someone will fix this :)
> 
> regards,
> fritz budiyanto
> 
> 
> __________________________________
> Do you Yahoo!?
> The New Yahoo! Search - Faster. Easier. Bingo.
> http://search.yahoo.com
> 
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>

Attachment: packet-wtp.c.diff
Description: Binary data