Ethereal-dev: Re: [Ethereal-dev] code cleanups for smb-stats and filter-dialog for mgcp-stats

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Fri, 25 Apr 2003 13:57:32 -0700
On Fri, Apr 25, 2003 at 08:53:55PM +0200, Lars Roland wrote:
> I have added a filter dialog for the mgcp-stats and created a new source 
> file, where we can put gui functions used by statistic taps.
> 
> the file contains only the add_table_entry function and is used only by 
> the mgcp-statistics at the moment.
> 
> please check in.
> 
> I also reduced redundant code in the smb_stat functions and fixed the 
> init in tap-smbstat.c. They use now code from timestats.c .

Checked in.

Note that, as per my mail within the past couple of days, the statistics
taps should perhaps use a GtkCList on GTK+ 1.2.x, and a
GtkTreeView/GtkListStore on GTK+ 2.x, rather than using a table.  That
might make it easier for that stuff to be scrollable, and also make it
sortable by column value.