It does so yes and I think there are both good and bad points to that.
The good thing is that the table only displays those values that are
non-null and this makes the
data easier to read for humans.
The bad thing is that we no longer know whether a specific call will be
present in the
oputput table any more and thus it gets more complicated to do things like
adding multiple -z fields on the commnd line for tehtereal for different say
smb response time intervals
in order to generate histograms.
If we alsays know that the call will be there even if are no calls, then a
simple
grep and sed will be sufficient to extract all data. We dont have to do
extra checks to check if it
is there or not.
Example: -R "not frame" -z "smb,rtt,smb.time<0.01" -z
"smb,rtt,smb<time>=0x01&&smb.time<0.02" ...
then just pipe it to | grep "ReadAndX" | some sed magic
and voila very simple we will get a histogram over the executiontime of
"ReadAndX"
This can be done for NFS but not for SMB due to the difference in handling
procedures that has no calls.
Maybe we should have a flag that specifies whether to put all procedures in
teh table or if only to put procedures that actually has call data in the
table.
As far as changing the table to a (sortable) list and make the list
scrollable so we are not limited to the height of the stat window.
We should definitely implement the changes described in your prev post.
It would be very useful, also it would reduce code duplication since all the
rtt stat taps basically share large parts of almost identical code which is
duplicated in each tap.
Moving it out into a separate file shared by all rtt taps would reduce code
size and also reduce the amount of GTK specific code, making it much easier
to port the gui to a different toolkit.
It would also make it easier to develop rtt stats for other protocols.
Currently there are only a few protocols that support rtt stats. We should
get all other protocols supported as well.
Another problem in the gui for rtt is visible in DCERPC rtt. Click the
menu to select the protocol to calculate rtt for.
There are too many DCERPC protocols supported for the (non-scrollable)
single column menu so we cant see all the protocols. This menu should
either be changed to be multicolumn or to be scrollable.
I dont know enough gtk to know how to fix that.
----- Original Message -----
From: "Guy Harris"
Sent: Friday, April 25, 2003 7:50 AM
Subject: Re: [Ethereal-dev] Some thoughts about statistics taps
> On Thu, Apr 24, 2003 at 02:48:28PM -0700, Guy Harris wrote:
> > Also, should the table omit procedures for which there are no calls?
>
> The SMB RTT table appears to do so.
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
