-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I'm using the CVS version of Ethereal on a Mandrake 9 box, with kernel 2.5.53,
and X 4.2.99.3; and I've noted a couple of issues:
1. The Display->Match and Display->Prepare sub-menu items are disabled when
you don't have any of the field selected in the middle pane. However the menu
items themselves are not disabled.
2. Tools->TCP Stream Analysis is enabled even when you don't have a capture.
3. When you enter a broken capture filter, the dialog box refers to an "Add
expression button", which doesn't appear to exist - it is only applicable to
display filters.
I can't seem to fix 1 and 2, although I did play around with it, and there is
a comment in gtk/menu.c around line 461 that looks like the problem is
possibly intentional.
3 should be addressed in the attached patch. Note that I'm a GTK dunce, so
please review before applying. Feel free to fix the other issues too!
Brad
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
iD8DBQE+o7z4W6pHgIdAuOMRAnYdAKCmIvaRaE/Gd7bjzFQ7DlguWjyp7wCgrkxm
OI/PQSzQ0nBiUfiXNKbvgD4=
=boiQ
-----END PGP SIGNATURE-----
? autom4te-2.5x.cache
? epan/autom4te-2.5x.cache
? wiretap/autom4te-2.5x.cache
Index: gtk/filter_prefs.c
===================================================================
RCS file: /cvsroot/ethereal/gtk/filter_prefs.c,v
retrieving revision 1.44
diff -u -3 -p -r1.44 filter_prefs.c
--- gtk/filter_prefs.c 2 Mar 2003 13:46:01 -0000 1.44
+++ gtk/filter_prefs.c 21 Apr 2003 09:38:59 -0000
@@ -1126,11 +1126,17 @@ filter_new_bt_clicked_cb(GtkWidget *w, g
g_list_foreach(get_filter_dialog_list(list), new_filter_cb, &args);
} else {
/* Give the user some basic directions on how to use the 'new' button */
- simple_dialog(ESD_TYPE_WARN, NULL,
- "You have left either the 'Filter name' or 'Filter string' field empty.\n"
- "To add a new filter, enter a name for the filter, and enter the expression\n"
- "for the filter or use the 'Add Expression...' button to construct an\n"
- "expression, then click 'New'.");
+ if (CFILTER_LIST == list)
+ simple_dialog(ESD_TYPE_WARN, NULL,
+ "You have left either the 'Filter name' or 'Filter string' field empty.\n"
+ "To add a new filter, enter a name for the filter, and enter the expression\n"
+ "for the filter.");
+ else /* DFILTER */
+ simple_dialog(ESD_TYPE_WARN, NULL,
+ "You have left either the 'Filter name' or 'Filter string' field empty.\n"
+ "To add a new filter, enter a name for the filter, and enter the expression\n"
+ "for the filter or use the 'Add Expression...' button to construct an\n"
+ "expression, then click 'New'.");
}
}
