Ethereal-dev: Re: [Ethereal-dev] Updates for packet-dcerpc-tkn4int.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Ronnie Sahlberg" <ronnie_sahlberg@xxxxxxxxxxxxxx>
Date: Sat, 12 Apr 2003 20:14:32 +1000
Looks really good.

Some points:
Fix the guint64 issue that guy pointed out earlier. It should be easy as
long as you do not
plan to do arithmetics on the 64 bit values.
Ethereal has code in the file Guy pointed to to handle 64 bit integers even
on platforms where
there is no 64 bit scalar integer type.
You might need to update the dissect_ndr_uint64 code to handle both le/be
types.
I am not sure but it might already do so, check the code.

Second:
Add your name to the head of the file so people interested in that
particular decoder knows who wrote
the support for that protocol.

Third:
Is there available on the web IDL files for that interface?
If so, can you add a hyperlink pointing to the idl file?


best regards
    ronnie s

----- Original Message -----
From: "Jaime Fournier"
Sent: Thursday, April 10, 2003 12:40 PM
Subject: [Ethereal-dev] Updates for packet-dcerpc-tkn4int.c


> Please review, and submit this patch.
> This is the first of many updates I need to submit,
> once I have cleaned them up, and removed external
> macros. Included is a trace of tkn4int packets.
>
> Thanks!
>
> =====
> Jaime Fournier