Hi, looks good
very minor changes i would like to see:
put g711.c in ethereal/ instead of ethereal/gtk/ since later someone may
want to use the feature also for
tethereal.
create g711.h which holds the prototypes so you dont include the .c file in
the actual tap file.
apart from that, it looks good to me.
fix these issues and i will check it in.
best regards
ronnie sahlberg
also, comments on what is unclear and what can be improved in README.tapping
are most welcome
----- Original Message -----
From: "Miha Jemec"
Sent: Thursday, March 06, 2003 2:18 AM
Subject: [Ethereal-dev] Ethereal addition for analysing RTP data
> Hi!
>
> After quite some time here is the rewritten version of RTP analysing
> tool. It uses now the tap system (I had to change the packet-rtp.c and
> packet-rtp.h) and with the intention of being OS independent it doesn't
> make possible to play the voice directly through the sound card but has
> the possibility to save it in a file for later listening. How it works
> is described in code itself (I tried to put many comments there). There
> are still some open questions or problems (look for XXX). I was able to
> test it only under Intel machine with Linux OS, so test on other OS
> would be welcome.
>
> Attached files are:
>
> rtp.jpg - screenshot
> tap_rtp.c - actual code, that goes into gtk/ directory
> g711.c - routines for converting alaw or ulaw to linear, goes into gtk/
> as well
>
> I also modified some other files (ethereal 0.9.8):
>
> in gtk/menu.c one more line under "Tools":
>
> ITEM_FACTORY_ENTRY("/Tools/_RTP analysis...", NULL, rtp_analyse_cb, 0,
> NULL, NULL),
>
>
> in packet-rtp.h added following structure at the end:
>
> struct _rtp_info {
> gboolean info_padding_set;
> gboolean info_marker_set;
> unsigned int info_payload_type;
> unsigned int info_padding_count;
> guint16 info_seq_num;
> guint32 info_timestamp;
> guint32 info_sync_src;
> guint info_data_len;
> };
>
>
> in packet-rtp.c: diff is attached
>
>
> Because I'm not very comfortable with automake , autoconf, ... I just
> added some lines by hand to compile:
>
> In etereal_tap_register two more lines:
>
> { extern void register_tap_listener_gtkrtp (void);
> register_tap_listener_gtkrtp ();}
>
> In gtk/Makefile in line am__objects_1 =
> added tap_rtp.$(OBJEXT)
>
>
> I would be glad to get any comments.
> Regards,
> Miha
>
>
>
