Ethereal-dev: Re: [Ethereal-dev] patch for packet-ncp2222.inc to fix GLIB-CRITICAL error.

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Greg Morris" <GMORRIS@xxxxxxxxxx>
Date: Tue, 25 Feb 2003 14:17:36 -0700
Guy,
 
The hash just contains an entry for the conversation, EID value, and name. This should be constant for the trace.
 
I changed the patch to not utilize the visited flag and to instead leave the hash until the trace file is either closed or reloaded.
 
Let me know if this is not acceptable,
Greg

>>> Guy Harris <guy@xxxxxxxxxx> 2/25/2003 1:47:34 PM >>>
On Tue, Feb 25, 2003 at 01:35:47PM -0700, Greg Morris wrote:
> I hate to appear dumb but is the reason for this because after the
> trace has been opened and dissected then if you filter the trace then
> the lookup will not be processed on these packets because they already
> have the flag set?

That's one reason.

Another reason is that if you subsequently click on a packet the lookup
will not be processed on that packet because it already has the flag
set, and if you ask Ethereal to print the packets the lookup will not be
processed on that packet because it already has the flag set, etc..

> If so would it be better to leave the hash until the trace is closed?

If only one value is associated with a given EID (i.e., if the
association of values with EIDs doesn't change over time), yes, that'd
be the right answer.

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev

Attachment: packet-ncp2222.inc.diff
Description: Binary data