Ethereal-dev: Re: [Ethereal-dev] Updates to NCP Dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Greg Morris" <GMORRIS@xxxxxxxxxx>
Date: Wed, 19 Feb 2003 17:29:18 -0700
Guy,
 
I am working on Windows with MickeySoft Visual C++. I do not get the same warnings. I would be more then happy to fix them if I can see them.
 
Greg

>>> Guy Harris <guy@xxxxxxxxxx> 2/19/2003 2:49:16 PM >>>
On Wed, Feb 19, 2003 at 01:07:19PM -0700, Greg Morris wrote:
> The following fixes are included in this update.

Checked in, with a ";" removed from some

    if (XXX);
    {
        ...
    }

code - GCC warned of a null body for the "if" statement, and it looked
as if it was intended to be

    if (XXX)
    {
        ...
    }

(I think you're developing on Windows - should we be passing arguments
to the C compiler to get it to produce more warnings and, if we do so,
will we get swamped with bogus-but-unfixable warnings?)