Ethereal-dev: Re: [Ethereal-dev] packet-giop.c enhancements: ServiceContexts, RTCORBA prioriti

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Craig Rodrigues <rodrigc@xxxxxxxxx>
Date: Fri, 14 Feb 2003 12:04:59 -0500
On Thu, Feb 13, 2003 at 11:17:04PM -0800, Guy Harris wrote:
> On Thu, Feb 13, 2003 at 01:42:37PM -0800, Guy Harris wrote:
> > (I also have some captures that I'm not sure the new dissector correctly
> > dissects; they're at home, and I haven't had time to look at them, and
> > should, in any case, only do so after any subsequent patches are checked
> > in.)
> 
> I've looked at them - none of the patches fixed the problem, so I
> checked in a fix; it wasn't handling service contexts correctly or, at
> least, wasn't handling service contexts other than Real-Time CORBA
> priorities correctly.


What problem are you talking about?  I tested with other service contexts
and it worked, ie. it defaulted to unknown.  That is acceptable behavior,
until more code is added to dissect other types of ServiceContexts. 
Your patch actually broke the correct dissection of RTCorbaPriorities.

Can you revert it?

-- 
Craig Rodrigues        
http://home.attbi.com/~rodrigc
rodrigc@xxxxxxxxx