Ethereal-dev: Re: [Ethereal-dev] Patch to packet-wbxml.h

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Fri, 14 Feb 2003 00:30:16 +0100
On Thu, Feb 13, 2003 at 03:43:58PM +0100, Biot Olivier wrote:
> Attached patch to packet-wbxml.h provides:
>   Decoding of WML 1.0 and PROV 1.0.

Looking at the patch I noticed that quite a lot of static variables
are declared in the .h file. IMO, this is not the right thing to do.
Could you please move the contents of the .h file into the .c file
so the .h file can be deleted? There are already more thatn enough
files in our top level directory. I case you really dislike removing
the .h file: Could you please at least move the variable declarations
into the .c file?

Thanks
         Jörg


--
Joerg Mayer                                          <jmayer@xxxxxxxxx>
I found out that "pro" means "instead of" (as in proconsul). Now I know
what proactive means.