Ethereal-dev: Re: [Ethereal-dev] Service Location Protocol

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Brad Hards <bhards@xxxxxxxxxxxxxx>
Date: Thu, 13 Feb 2003 06:47:54 +1100
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 12 Feb 2003 21:06, Christoph Bartoschek wrote:
> Hi,
>
> IMHO Line 706 in packet-srvloc.c should be
>
> proto_tree_add_uint(srvloc_tree, hf_srvloc_xid, tvb, offset + 10, 2,
>
> instead of
>
> proto_tree_add_uint(srvloc_tree, hf_srvloc_xid, tvb, offset + 10, 3,
I don't follow. RFC2608 shows:
<quote>
8. Required SLP Messages

   All length fields in SLP messages are in network byte order.  Where '
   tuples' are defined, these are sequences of bytes, in the precise
   order listed, in network byte order.

   SLP messages all begin with the following header:

      0                   1                   2                   3
      0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
     |    Version    |  Function-ID  |            Length             |
     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
     | Length, contd.|O|F|R|       reserved          |Next Ext Offset|
     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
     |  Next Extension Offset, contd.|              XID              |
     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
     |      Language Tag Length      |         Language Tag          \
     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

</quote>

How do you get two bytes out of that? Or are you looking at something that is 
doing SLPv1?

In any case, can you send me a capture showing the problem?

Brad
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE+SqTqW6pHgIdAuOMRAn5UAJ9jN/gt7if+0isdj5YcuYDiS2INBQCfWAnv
npZtCTMnhv8ifLNmNrcwlF4=
=UP7d
-----END PGP SIGNATURE-----