Wireshark · Ethereal-dev: Re: [Ethereal-dev] Changed cause code "strings " in packet-q931to conform to q.850

[Guy Harris <guy@xxxxxxxxxx>]

On Thu, Feb 06, 2003 at 05:05:26PM +0100, Anders Broman (EAB) wrote:
> Included changes in q.931 dissector to conform to q.850 cause codes +

Unfortunately, that will, I presume, render the Q.931 dissector less
useful for dissecting, well, regular ISDN Q.931 traffic, and probably
H.323 traffic as wel, as it won't correctly dissect cause codes in that
traffic.

Instead, what should probably be done is:

	have a "dissect_cause_ie()" routine that takes a tvbuff_t *, an
	offset, a length, a proto_tree *, *and* a const value_string *
	as arguments - it's code would be what's in
	"dissect_q931_cause_ie()", except that it uses the specified
	value_string table to dissect the cause code;

	the Q.931 dissector should call it with the current cause code
	value_string table, which should not be modified;

	the ISUP dissector should call it with a new Q.850 cause code
	value_string table.

Also, you should submit your changes as patches rather than as new
versions of the source file, if possible - we could generate the patch
from your source, and apply it, if the Q.931 dissector happens to change
after you make your changes, but that's a bit inconvenient.