Ethereal-dev: Re: [Ethereal-dev] MPLS over CHDLC patch ...

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Mon, 27 Jan 2003 11:34:04 -0800
On Sun, Jan 26, 2003 at 07:19:23PM +0100, Hannes Gredler wrote:
> pls find attached a [mini] patch that registers the MPLS
> dissector within the C-HDLC dissector;

Checked in.

BTW, is "MPLS multicast" not used over broadcast networks such as
Ethernet (e.g., is it designed to handle multicasting over
point-to-point links)?  It's registered with PPP and Cisco HDLC, but not
registered as an Ethertype.

Also, it would be possible to have the Cisco HDLC dissector get a handle
for the "ethertype" dissector table, and first try the Cisco HDLC
dissector table and, if no dissector is found, try the "ethertype"
table; that would obviate the need for protocols that don't have special
Cisco HDLC types to register themselves with "chdlc".

However, that doesn't help with the "chdlc_vals[]" value_string table;
I'm not sure what the right fix would be there, but it'd be nice to have
"chdlc_vals[]" inherit stuff from "etype_vals[]" and then put its own
items on top of it.  (Are there any protocols that are different from
each other but that share an Ethertype/CHDLC type value?)