Ethereal-dev: Re: [Ethereal-dev] SCTP Payload Protocol Identifiers

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Michael Tuexen <Michael.Tuexen@xxxxxxxxxxxxxxxxx>
Date: Thu, 16 Jan 2003 09:35:41 +0100
Dear all,
see my comments below.
Best regards
Michael
On Wednesday, Jan 15, 2003, at 21:19 Europe/Berlin, Guy Harris wrote:


On Wed, Jan 15, 2003 at 11:21:15AM +0100, Michael Tuexen wrote:

I will remove the old ASAP PPID after updating the ASAP dissector.
We still have (the only) Open Source implementation of ASAP out
there using the old one.


Are there any non-Open Source ASAP implementations using the old one?
I think no. Because I have choosen the PPID to 'approximate' FreeBSD1 in Hex FAEEB5D1. 


This will be updated soon.


I checked in a change to packet-asap.c to use both the old and new
PPIDs; if the old PPID isn't necessary, remove the

  /* XXX - is 0xFAEEB5D1 still being used? */
dissector_add("sctp.ppi", ASAP_OLD_PAYLOAD_PROTOCOL_ID, asap_handle); 

stuff from packet-asap.c, remove

/*
 * XXX - this came from "packet-asap.c"; is this some PPID value used
 * before 11 was assigned?
 */
#define ASAP_OLD_PAYLOAD_PROTOCOL_ID  0xFAEEB5D1

from sctpppids.h, and remove

  { ASAP_OLD_PAYLOAD_PROTOCOL_ID,        "ASAP (old)" },

from packet-sctp.c.