On Thu, Jan 09, 2003 at 12:24:32PM -0800, Guy Harris wrote:
> On Thu, Jan 09, 2003 at 02:08:45PM -0600, Albert Chin wrote:
> > --with-plugins is honored *only* by plugins/docsis/Makefile.am.
>
> Well, if there's something done only by the DOCSIS makefile, I'll have
> to look into this more - I have a "regression baseline" version of
> Ethereal installed on a machine at home, which I use for regression
> tests, and it installs its plugins in a directory with "vanilla"
> appended to the version number so that the "regression baseline" version
> won't use the same plugins as the current version.
>
> The only case where I've seen problems with that was with the DOCSIS
> plugins, so if there are any plugin installation problems, I'd currently
> expect them to be with the DOCSIS plugins and not with the other plugins,
> rather than being with all plugins *except* for the DOCSIS plugins.
> (Re-installing the two versions seemed to clear up the problem I saw, so
> I'm not sure what caused the problem.)
Take a look at configure.in. It's easy enough to tell that
--with-plugins is honored only by plugins that install to
@PLUGIN_DIR@. The patch below fixes --with-plugins for us.
plugindir="$libdir/ethereal/plugins/$VERSION"
PLUGIN_DIR="$plugindir"
AC_ARG_WITH(plugins,
...
case "$withval" in
"" | y | ye | yes )
...
n | no)
have_plugins=no
;;
*)
...
PLUGIN_DIR="$withval"
--
albert chin (china@xxxxxxxxxxxxxxxxxx)
-- snip snip
--- plugins/giop/Makefile.am.orig Thu Jan 9 13:47:23 2003
+++ plugins/giop/Makefile.am Thu Jan 9 13:47:41 2003
@@ -28,7 +28,7 @@
INCLUDES = -I$(top_srcdir)
-plugindir = @plugindir@
+plugindir = @PLUGIN_DIR@
plugin_LTLIBRARIES = cosnaming.la coseventcomm.la
cosnaming_la_SOURCES = packet-cosnaming.c moduleinfo.h
--- plugins/gryphon/Makefile.am.orig Thu Jan 9 13:47:23 2003
+++ plugins/gryphon/Makefile.am Thu Jan 9 13:47:45 2003
@@ -25,7 +25,7 @@
INCLUDES = -I$(top_srcdir)
-plugindir = @plugindir@
+plugindir = @PLUGIN_DIR@
plugin_LTLIBRARIES = gryphon.la
gryphon_la_SOURCES = packet-gryphon.c packet-gryphon.h moduleinfo.h
--- plugins/mgcp/Makefile.am.orig Thu Jan 9 13:47:23 2003
+++ plugins/mgcp/Makefile.am Thu Jan 9 13:47:49 2003
@@ -25,7 +25,7 @@
INCLUDES = -I$(top_srcdir)
-plugindir = @plugindir@
+plugindir = @PLUGIN_DIR@
plugin_LTLIBRARIES = mgcp.la
mgcp_la_SOURCES = packet-mgcp.c moduleinfo.h
--- plugins/pcli/Makefile.am.orig Thu Jan 9 13:47:23 2003
+++ plugins/pcli/Makefile.am Thu Jan 9 13:47:52 2003
@@ -25,7 +25,7 @@
INCLUDES = -I$(top_srcdir)
-plugindir = @plugindir@
+plugindir = @PLUGIN_DIR@
plugin_LTLIBRARIES = pcli.la
pcli_la_SOURCES = packet-pcli.c moduleinfo.h
