Ethereal-dev: Re: [Ethereal-dev] Capture time display bug if minutes > 60 (still broken)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Thu, 2 Jan 2003 10:59:32 -0800
By "still broken" do you mean "still broken in 0.9.8", or do you mean
"still broken in the current CVS version"?

If the former, then the statement is true, then I'm not sure I
understand why the word "still" was used in the subject line - the fix
was checked into revision 1.197 of capture.c.  (0.9.8 was released on
December 7:

	http://www.ethereal.com/lists/ethereal-announce/200212/msg00000.html

but the original bug report about the problem was sent on December 17th,
after 0.9.8 was released:

	http://www.ethereal.com/lists/ethereal-dev/200212/msg00187.html

so it's not surprising that it's still broken in 0.9.8, given that
either nobody noticed it was broken, or nobody bothered to tell any
developer with checking privileges that it was broken, until after 0.9.8
was released).

If the latter, then:

On Thu, Jan 02, 2003 at 05:22:27PM +0000, Tim Clymo wrote:
> IMHO, the correct expression in capture.c for displaying minutes should be:
> 
> (long)(cur_time/60%60)

For what values of "cur_time" is "((cur_time%3600)/60)" (which is the
expression used in the current CVS tree) not equal to
"(cur_time/60%60)"?