Ethereal-dev: Re: [Ethereal-dev] [Patch] revised: tap-tcp_close

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Jason House <jhouse@xxxxxxxxx>
Date: Tue, 03 Dec 2002 17:06:51 -0500
I like your method... very simple :)

I've implemented the method you outlined, but now realize that I can't
rely on the fields in pinfo since they could get modified after the call
to dissect_tcp...   I'll make that fix in the relatively near future and
submit an updated patch...

Are there any other problems with tap-tcp_close while I'm at it?
What thoughts are there on the modifications to conversations?



Ronnie Sahlberg wrote:
> I think a much simpler solution, which is used to solve the same/similar
> problem elsewhere
> all over the place would be to add to dissect_tcp(){
> 
> static int cur_tcp_hdr_struct=0;
> static struct tcp_header tcph[4], *tcp;
> 
> tcp=&tcph[tcp_hdr_struct];
> tcp_hdr_struct++;
> if(tcp_hdr_struct>=4)
>     tcp_hdr_Struct=0;
> 
> adn then from there on use tcp->    everywhere in disect_tcp()