Wireshark · Ethereal-dev: [Ethereal-dev] packet-wtp.c: WTP packet sequence number patch

[Biot Olivier <Olivier.Biot@xxxxxxxxxxxxxxx>]

Hi all,

There is an inconsistency in WTP display of packet sequence numbers:
sometimes BASE_DEC is used, sometimes BASE_HEX.

As has been discussed in earlier mails, this packet sequence numbers are
unsigned integers and not opaque data, so they should be represented as
decimal values. The following patch fixes this:

--- packet-wtp-1.40.c   2002-12-02 12:25:30.000000000 +0100
+++ packet-wtp.c        2002-12-02 12:28:31.000000000 +0100
@@ -798,14 +798,14 @@
        { &hf_wtp_header_sequence_number,
            {   "Packet Sequence Number",
                "wtp.header.sequence",
-               FT_UINT8, BASE_HEX, NULL, 0x00,
+               FT_UINT8, BASE_DEC, NULL, 0x00,
                "Packet Sequence Number", HFILL
            }
        },
        { &hf_wtp_header_missing_packets,
            {   "Missing Packets",
                "wtp.header.missing_packets",
-               FT_UINT8, BASE_HEX, NULL, 0x00,
+               FT_UINT8, BASE_DEC, NULL, 0x00,
                "Missing Packets", HFILL
            }
        },

Please check in.

Regards,

  Olivier Biot                     Siemens ATEA IC D MS C
O-------------------------------o-------------------------------O
| Phone   : +32  (14) 25 39 84  |  Address: Atealaan 34         |
| Fax     : +32  (14) 22 29 94  |           2200 Herentals      |
| Cellular: +32 (474) 96 32 09  |           Belgium             |
O-------------------------------o-------------------------------O
~  "I love deadlines.  I especially love the swooshing sound    ~
~   they make as they go flying by."               - Dilbert    ~
_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev