Ethereal-dev: Re: [Ethereal-dev] Re: [Ethereal-users] Netlib SQL decoder crashes

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Tue, 26 Nov 2002 12:09:20 -0800
On Fri, Nov 22, 2002 at 04:41:24PM -0800, Guy Harris wrote:
> On Tue, Nov 19, 2002 at 11:03:12PM +0100, Martin Regner wrote:
> > I don't know if the fix Gerald Combs made a few days ago would solve this crash. 
> > http://www.ethereal.com/lists/ethereal-cvs/200211/msg00142.html
> 
> It doesn't.
> 
> I ran Ethereal on the capture, and it crashed.  It doesn't crash when I
> run "tethereal" or "tethereal -V" on the same capture.

I checked in a change to zero out a data structure in the Netlib
dissector before using it, as there is a possibility that the routine
that's assumed to initialize it ("load_netlib_data()") might not do so
as it won't see any TDS protocol data for the frame.

That seems to have fixed the crash.

However, I still suspect the defragmentation stuff should be redone, as
per my previous mail.