Ethereal-dev: Re: [Ethereal-dev] tapping commentary

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Pia Sahlberg" <piabar@xxxxxxxxxxx>
Date: Tue, 22 Oct 2002 22:37:30 +0000
From: Guy Harris Subject: Re: [Ethereal-dev] tapping commentary
Date: Tue, 22 Oct 2002 14:24:02 -0700

On Mon, Oct 21, 2002 at 11:51:05PM +0000, Pia Sahlberg wrote:
> Do you mean that the tap should react to actually selecting the menu
> item, or just when a tap listener has been started from the menu?

When you select the menu item, Ethereal should start scanning through
all packets, dissect each packet, and hand it to the tap.

The tap in question wouldn't necessarily be one that was selected from
the command line; this is a way to get statistics, etc. that you didn't
ask for when you started Ethereal.

No, I understand that. But, shoud this feature be tied to actually
clicking on the menu item or should it be a sideeffect of the menu-item calling gtk_rpcstat_init() and then gtk_rpcstat_init() makes the nessecary calls to do a rescan.

I can provide patches in the next day or so to change gtk_rpcstat_init() (and other taps) to perform a rescan when called.

> Do you mean the epan_dissect_t *edt variable?

I was just thinking of edt->tree.

OK. I can provide a patch that adds this variable to the _packet() callback.
Should I pass edt or edt->tree (does edt hold any other useful information besides ->tree?) to the callback?


> I did not know that that variable was useful.

It would be useful for a tap that didn't involve any changes to
dissectors to cause stuff from the dissector to be passed to the tap.

OK. Can actual field values like the value of "ip.addr" be extracted from edt->tree? if so it would be very useful.

best regards
  ronnie sahlberg


_________________________________________________________________
Surf the Web without missing calls! Get MSN Broadband. http://resourcecenter.msn.com/access/plans/freeactivation.asp