Ethereal-dev: Re: [Ethereal-dev] Re: patches for arcnet support

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Peter Fales <psfales@xxxxxxxxxx>
Date: Fri, 18 Oct 2002 16:14:25 -0500
Great!  Thanks for the help.  I'll pull it down and give a try.

-- 
Peter Fales			  Lucent Technologies, Room 1C-436
N9IYJ            		  2000 N Naperville Rd PO Box 3033
internet: psfales@xxxxxxxxxx	  Naperville, IL 60566-7033
			 	  work:	(630) 979-8031

On Fri, Oct 18, 2002 at 02:11:16PM -0700, Guy Harris wrote:
> On Fri, Oct 18, 2002 at 09:41:45AM -0500, Peter Fales wrote:
> > Thanks for all your suggestions on cleaning up the code for arcnet
> > support.  I was able to build with the latest libpcap from CVS, so 
> > no libpcap changes were needed.  I've attached the patches to 
> > ethereal-0.9.7.  See what you think of this.
> 
> I've checked them in, with some changes:
> 
> 	I renamed "packet-arcnet.h" to "arcnet_pids.h", as it only
> 	exports the protocol ID values (and that's all other dissectors
> 	need);
> 
> 	I made the ARCNET dissector set the Protocol and Info columns
> 	before fetching anything from the packet (so that the columns
> 	get set even if the frame is short);
> 
> 	I didn't register the ARCNET dissector by name, I used
> 	"create_dissector_handle()" to create an anonymous handle for it
> 	(as no other dissector refers to it directly, it's just called
> 	through the "wtap_encap" dissector table);
> 
> 	I got rid of some unneeded #includes (Joerg will probably purge
> 	any that I've left :-)).
> 
> I'll look at adding a new address type so that the ARCNET address can
> show up in the source and destination address columns in the display.