Wireshark · Ethereal-dev: [Ethereal-dev] Q on data structure in Ethereal & FCIP

[ddutt@xxxxxxxxx]

Hi,

I've finished adding a decoder to FCIP and some FC protocols as well. Before I
go about releasing it, I have a couple of questions on how people would like to
see the code structured.

1. When decoding FC frames, I decided to display FC addresses instead of TCP/IP
   or Ethernet address in the protocol summary window. I also wanted to carry
   the FC addresses forward to other protocols and to this end, I've written
   the code to set the src and dst fields in the pinfo structure to the
   equivalent FC fields. 

   Do people see a problem with this ? 

2. I've added OXID and RXID fields to the pinfo structure as I'd like to add
   these fields as columns to the protocol summary field. Hope this is OK.

2. I've added routines to print WWN and such as strings and have added them to
   the to_str.c file. Would people prefer that I add them to a separate file 
   such as to_fcwwn.c ?

Thanks,

Dinesh
-- 
Knowing is not enough; we must apply. Willing is not enough; we must do.
                                           - Johann Wolfgang von Goethe