-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Tue, 1 Oct 2002 18:14, Ronnie Sahlberg wrote:
<snip>
> If you want the stuff checked in instead of only reviewed please tell so in
> the posting.
> Often people post work in progress only to get peer review on works in
> progress and thus does not want it checked in until they are happy with it.
That was the intent, until now. Never having coded ethereal, it naturally took
me a while to get the right mind set.
The attached patch (which obsoletes my badly named -30oct02 version :) adds
SLPv2 support (RFC2608) to the existing SLPv1 support. The only change
between this and my last patch is the removal of the text markers, which
weren't doing anything meaningful.
MD5 sum of patch:
6347c3ae77bd80d90ca27e8b4e25a135 ethereal-slp2-02oct02.patch.gz
Notes on packet-srvloc.c, as modified by this patch:
* Dissection of authentication blocks is broken. I don't use authentication,
and need to decode the RFC a few more times before this section is
transparent to me.
* Dissection of SAAdvert and DAAdvert is probably OK, but hasn't been tested.
My network doesn't produce them yet.
* Dissection of SLPv1 hasn't been tested, since I have no traces or tools to
produce them. I haven't tried to rework it at this stage, in an attempt to
leave it "as working as it ever was".
Please review, and check in if appropriate.
I will do maintenance on this as time (and information/traces) allow.
Brad
- --
http://conf.linux.org.au. 22-25Jan2003. Perth, Aust. Tickets booked.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE9mqVCW6pHgIdAuOMRAsw7AKCxiELQ8E5+3a+fegQYywYHsDHgswCgwta1
gctCeCorQHLU3+RLejFI5tI=
=xspb
-----END PGP SIGNATURE-----
Attachment:
ethereal-slp2-02oct02.patch.gz
Description: GNU Zip compressed data
