Ethereal-dev: Re: [Ethereal-dev] NDPS dissector for Ethereal

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Greg Morris" <GMORRIS@xxxxxxxxxx>
Date: Mon, 23 Sep 2002 11:19:47 -0600
When compiling on Win32 I do not get these warnings. I try to correct...
 
Thanks


>>> Joerg Mayer <jmayer@xxxxxxxxx> 09/23/02 11:17AM >>>
On Mon, Sep 23, 2002 at 10:43:36AM -0600, Greg Morris wrote:
> Attached is an attempt to dissect Novell Distributed Print Services.
> NDPS runs on top of SPX and TCP.

Checked in. Please note that I got a few warnings while compiling your
new code:

============================================
packet-ncp.c:93: warning: type defaults to `int' in declaration of `ncp_nds_true'
packet-ncp.c:85: warning: `hf_ping_version' defined but not used
packet-ncp.c:93: warning: `ncp_nds_true' defined but not used
packet-ndps.c: In function `dissect_ndps_common':
packet-ndps.c:730: warning: empty body in an if-statement
packet-ndps.c:582: warning: `conn_ctrl' might be used uninitialized in this function
packet-ndps.c: In function `proto_reg_handoff_ndps':
packet-ndps.c:894: warning: unused variable `spx_handle'
============================================

Please have a look at it. I also added the new files to Makefile.am.

  Ciao
           Jörg
--
Joerg Mayer                                          <jmayer@xxxxxxxxx>
I found out that "pro" means "instead of" (as in proconsul). Now I know
what proactive means.