Ethereal-dev: [Ethereal-dev] Small bug in Ethereal EAP Response Nak handling

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Jouni Malinen <jkmaline@xxxxxxxxx>
Date: Sat, 7 Sep 2002 21:39:20 +0300
packet-eap.c seems to display incorrect value as eap_type_nak in EAP Nak  
packets. It displays eap_type ('Type') again in the 'Desired Auth Type',  
even though it should use the next byte from the packet. Patch included   
below.

In addition, proto_register_eap() seems to "eap.type" both with "Type"
and "Desired Auth Type". Should the latter one be something else?

Index: packet-eap.c
===================================================================
RCS file: /cvsroot/ethereal/packet-eap.c,v
retrieving revision 1.28
diff -u -u -r1.28 packet-eap.c
--- packet-eap.c	2002/08/28 21:00:12	1.28
+++ packet-eap.c	2002/09/07 18:21:45
@@ -415,7 +415,7 @@
       case EAP_TYPE_NAK:
 	if (tree) {
 	  proto_tree_add_uint(eap_tree, hf_eap_type_nak, tvb,
-			      offset, size, eap_type);
+			      offset, size, tvb_get_guint8(tvb, 5));
 	}
 	break;
       /*********************************************************************

-- 
Jouni Malinen                                            PGP id EFC895FA