Ethereal-dev: Re: [Ethereal-dev] more verbose IS-IS dissector ...

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Hannes Gredler <hannes@xxxxxxxxxxx>
Date: Fri, 30 Aug 2002 09:24:29 +0200
On Thu, Aug 29, 2002 at 11:53:16AM -0700, Guy Harris wrote:
| On Thu, Aug 29, 2002 at 11:20:38AM +0200, Hannes Gredler wrote:
| > pls find attached a patch that makes IS-IS more verbose in the INFO field;
| 
| Checked in (but without the MAC registration changes; I'm still
| unconvinced that they're the right way to get Ethereal to show
| well-known addresses symbolically).

guy,

seems you have forgot/missed something ...
we need to pass the pinfo pointer otherwise we cannot call
the col_ routines;

/hannes

@@ -221,22 +222,22 @@
        case ISIS_TYPE_L1_HELLO:
        case ISIS_TYPE_L2_HELLO:
        case ISIS_TYPE_PTP_HELLO:
-               isis_dissect_isis_hello(tvb, isis_tree, offset,
+               isis_dissect_isis_hello(tvb, pinfo, isis_tree, offset,
                        isis_type, isis_header_length, isis_system_id_len);
                break;
        case ISIS_TYPE_L1_LSP:
        case ISIS_TYPE_L2_LSP:
-               isis_dissect_isis_lsp(tvb, isis_tree, offset,
+               isis_dissect_isis_lsp(tvb, pinfo, isis_tree, offset,
                        isis_type, isis_header_length, isis_system_id_len);
                break;
        case ISIS_TYPE_L1_CSNP:
        case ISIS_TYPE_L2_CSNP:
-               isis_dissect_isis_csnp(tvb, isis_tree, offset,
+               isis_dissect_isis_csnp(tvb, pinfo, isis_tree, offset,
                        isis_type, isis_header_length, isis_system_id_len);
                break;
        case ISIS_TYPE_L1_PSNP:
        case ISIS_TYPE_L2_PSNP:
-               isis_dissect_isis_psnp(tvb, isis_tree, offset,
+               isis_dissect_isis_psnp(tvb, pinfo, isis_tree, offset,
                        isis_type, isis_header_length, isis_system_id_len);
                break;
        default:
@@ -326,4 +327,9 @@