My apologies for un-diff'ing.
Attached please find a diff against current CVS packet-isakmp.c containing:
1. Parsing of group description attribute (donno why it was missed so far).
2. Enumaration of # of transforms and # of payloads (just makes it easier to
look at).
3. Parsing of Vendor ID:
3.1 Identify several vendors' Vendor ID string (Microsoft, CyberGuard,
SafeNet, Check Point at the moment) - if anyone has more VendorID strings,
I'd be more than happy to add them.
3.2 Identify Vendor ID string of draft_ietf_ipsec_nat_t_ike_03 (NAT
traversal RFC draft).
3.3 Further parsing of Check Point's Vendor ID string, to include Check
Point product and version. If anyone has other vendors' parsing knowledge,
again, I'd be happy to add it.
I'd be grateful if it'll make it to 0.9.6.
Comments are welcome.
Y.
> -----Original Message-----
> From: ethereal-dev-admin@xxxxxxxxxxxx
> [mailto:ethereal-dev-admin@xxxxxxxxxxxx]On Behalf Of Guy Harris
> Sent: Sun, August 18, 2002 9:41 PM
> To: Yaniv Kaul
> Cc: Ethereal-Dev@xxxxxxxxxxxx
> Subject: Re: [Ethereal-dev] packet-isakmp.c modifications
>
>
> On Sun, Aug 18, 2002 at 12:04:58PM +0200, Yaniv Kaul wrote:
> > 1. Proper extraction of data from packet (removed bad tvb_get_ptr() and
> > casting the resulting pointer to a structure method).
> > 2. Printout of Initator and Responder cookies (per request from VPNC
> > organization).
>
> Checked in.
>
> > There was not point diff'ing as the first change is quite big.
>
> Well, one reason for sending changes as patches is compression; however,
> another reason is robustness in the face of *other* changes being
> applied to the file being changed, e.g. if some other change had been
> checked in after you'd done the diff, so even with big changes sending
> them out as patches can be a good idea.
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
Attachment:
isakmp.diff.gz
Description: Binary data
