Wireshark · Ethereal-dev: RE: [Ethereal-dev] [PATCH] -G option & doc/dfilter... change to i nclude hfinfo->blurb

[Khachaturov Vassilii <Vassilii.Khachaturov@xxxxxxxxxxxx>]

(Please forgive the newbie babble - this is my first ethereal patch
attempt).

While trying to get ethereal-doc set up locally, I realized there is a clone
of dfilter2sgml there which is not in sync with doc/dfilter2sgml in the
ethereal cvs
module.

Is this intentional? Should I submit a patch against ethereal-doc's
dfilter2sgml?
Maybe a link should be made in the server CVS repository from 
/ethereal/doc/dfilter2sgml
to /ethereal-doc/dfilter2sgml?
Should I send that patch here or to the ethereal-doc list?
(But keep in mind that the patch has to be applied along with the
epan/proto.c 
patch in order to make sense.)

And, can someone please tell me if the patch is welcome/what is missing
before
it can be checked in?

Thanks,
	Vassilii

> -----Original Message-----
> From: Vassilii Khachaturov [mailto:vassilii@xxxxxxxxxxxxxxx]
> Sent: Tuesday, August 13, 2002 4:02 PM
> To: ethereal-dev@xxxxxxxxxxxx
> Subject: [Ethereal-dev] [PATCH] -G option & doc/dfilter... 
> change to include hfinfo->blurb
> 
> 
> Included is a patch that modifies the -G option handling along
> with the postprocessing perl scripts to include the "blurb" 
> description,
> when present, into the resulting manpage.
> 
> (I guess one of the reason people rarely fill in the human-readable
> long field description is that until now the only place it
> is shown is the GUI version hint for a selected field.)
> 
> The pod pipeline works, but I haven't tested my dfilter2sgml change 
> - my environment Makefiles never seem to invoke it - I guess I need 
> to checkout ethereal-doc for it?
> 
> --- epan/proto.c	2002/08/02 21:29:39	1.71
> +++ epan/proto.c	2002/08/13 19:14:16
> @@ -3044,8 +3044,8 @@
>  			g_assert(parent_hfinfo);
>  
>  			enum_name = ftype_name(hfinfo->type);
> -			printf("F\t%s\t%s\t%s\t%s\n", 
> hfinfo->name, hfinfo->abbrev,
> -				enum_name,parent_hfinfo->abbrev);
> +			printf("F\t%s\t%s\t%s\t%s\t%s\n", 
> hfinfo->name, hfinfo->abbrev,
> +				
> enum_name,parent_hfinfo->abbrev, hfinfo->blurb);
>  		}
>  	}
>  }
> --- doc/dfilter2pod.pl	2001/04/19 23:17:30	1.2
> +++ doc/dfilter2pod.pl	2002/08/13 19:14:16
[remainder of the patch snipped]