Ethereal-dev: RE: [ethereal-dev] Hints for WAP WTP processing in packet-wtp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Tom Uijldert <Tom.Uijldert@xxxxxxx>
Date: Tue, 13 Aug 2002 08:49:54 +0200
> Damn. I have been working on a patch for decoding Info, 
> Error, Option, and
> PSN TPIs. Its been close to completion for a while.....I 
> actually spent time
> last week trying to get it in shape to send in.

Sorry about that...

> Your code looks different enough that it would take me a 
> while to add my
> extra decoding to it.
> 
> Guy, would it be possible to check Tom's code back out if I 
> sent you a more
> comprehensive diff? Tom, would you mind me doing this?

As already stated, the diff is huge due to re-indenting (and some other
clean-ups) so I doubt whether it would be of great help to you.

However, the actual changes for TPI-processing are fairly straightforward.

First off, I left the first pass to parse TPI's in to get correct lengths
for items that are hung into the proto-tree, so no changes there.

When all that is done, I just re-start the parsing of TPI's and call
wtp_handle_tpi() with his own "tvb", containing only that TPI.
There I create a subtree as TPI's are optional and could contain a whole
structure of information themselves.

So all you need to do is add the missing TPI information (error, SDU...)
within the switch-statement in that routine.

And no, I don't mind you changing stuff, that's what this is all about after
all.

Regards,
Tom Uijldert          Email: Tom.Uijldert@xxxxxxx