Ethereal-dev: Re: [Ethereal-dev] ntlmssp auth3 dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sat, 10 Aug 2002 14:16:44 -0700
On Fri, Aug 09, 2002 at 11:57:03PM -0400, dheitmueller wrote:
> Attached is the code necessary to dissect the auth3 message in the
> NTLMSSP protocol.
> 
> Also in the patch is a minor fix to interpret the negotiate_flags fields as 32 bit instead of 16.  

Checked in.

> Do we have an approach for handling unicode strings, so I can
> eliminate the duplicate code?

We don't have a general universal Ethereal-wide approach for handling
Unicode strings, but we don't need one in order to eliminate the
duplicate code - we just need to make the "packet-smb.c" version of
"get_unicode_or_ascii_string()" take a "Unicode or not" flag rather than
a "packet_info *" as an argument, change its callers appropriately, and
make it not static.  That's what I've done (and I moved it to
"packet-smb-common.c").