Ethereal-dev: Re: [Ethereal-dev] COL_INFO for andX commands

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Richard Sharpe <rsharpe@xxxxxxxxxx>
Date: Tue, 23 Jul 2002 05:47:11 +0930 (CST)
On Mon, 22 Jul 2002, Guy Harris wrote:

> On Mon, Jul 22, 2002 at 02:19:24PM +0930, Richard Sharpe wrote:
> > A quick way I can see to do it is to introduce an extra parameter to 
> > dissect_smb_command called first, set to true when dissect_smb_command is 
> > called by dissect_smb, and False when called on an andX.
> > 
> > Then we can choose whether to col_add_fstr or col_append_fstr.
> 
> The SMB dissector clears the Info column very early in the dissection
> process, so you can, presumably, always use "col_append_fstr()".

Yes, but you need a way to decide if you should output the ';'. It is 
going to look ugly to see:

  ; Session Setup & X MUMBLE\FROTZ; Tree Connect & X \\SERVER1\XYZSHARE

Last thing I want is for Ethereal to look ugly :-)

Regards
-----
Richard Sharpe, rsharpe@xxxxxxxxxx, rsharpe@xxxxxxxxx, 
sharpe@xxxxxxxxxxxx