Here is a minor tweak to give the user some feedback when using the
filter interface. In the current model, if the user clicks the "new"
button and the filter fields are empty, nothing happens. This can be
really confusing to users new to Ethereal. Now we give them an error
message telling them that the two fields need to be completed in order
to create the filter.
Has anyone seen a good filter configuration interface that is GPL, that
we could perhaps pull into Ethereal? This seems to be the major
complaint among the non-programmers in my office who use Ethereal. If
not, I'm getting annoyed enough with the current interface to consider
writing a new one.
-Devin
diff --context -r1.36 filter_prefs.c
*** filter_prefs.c 2002/05/02 23:49:21 1.36
--- filter_prefs.c 2002/06/22 17:58:32
***************
*** 979,984 ****
--- 979,988 ----
args.active_filter_l = filter_l;
args.nflp = fl_entry;
g_list_foreach(get_filter_dialog_list(list), new_filter_cb,
&args);
+ } else {
+ /* Give the user some basic directions on how to use the 'new'
button */
+ simple_dialog(ESD_TYPE_WARN, NULL,
+ "You have left either the 'filter name' or 'filter string' field
empty.\nTo add a new filter, enter a name for the filter, the expression
for the filter, then click 'new'");
}
}
--
Devin Heitmueller
Senior Software Engineer
Netilla Networks Inc
