Ethereal-dev: Re: [Ethereal-dev] bool keyword in prefs-int.h

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sat, 15 Jun 2002 18:00:04 -0700
On Fri, Jun 14, 2002 at 08:50:25AM -0700, Chris Waters wrote:
> The declaration for the preference structure in prefs-int.h uses the name
> 'bool' for a couple of the fields in the structure. bool is a keyword in C++
> and when compiling prefs-int.h with a C++ compiler (Borland C++ Builder in
> this case) the compiler complains. I haven't tried compiling with MSVC++,
> but its syntax highlighter thinks that bool is a keyword too.
> 
> I would like to suggest that the name of the field be changed to 'bool_val'.

I went with "boolp" and "boolval", instead, to parallel the handling of
"enump" and "enumval".

> The asn1_bool_decode function in the asn1.h file also uses bool as the name
> of a parameter.

I changed it to "boolean" rather than "bool_val", to parallel the
"integer" argument to the integral value decoding routines.