Hello Guy,
Much appreciated. Thanks very much.
Steve.
Guy Harris <gharris@xxxxxxxxx> on 13/06/2002 08:22:05
Sent by: Guy Harris <gharris@xxxxxxxxx>
To: Steve Housley/GB/3Com
cc: ethereal-dev@xxxxxxxxxxxx
Subject: Re: [Ethereal-dev] Review Request for New Dissector (LACP)
On Wed, Jun 12, 2002 at 05:41:19PM +0100, Steve Housley wrote:
> Thanks for your comments. I agree with all your suggestions and have
> incorporated the changes into my build and tested them.
> Attached are the latest files which have been modified. Would you please take
a
> further look (and that goes for anyone else)?
I cleaned up white space (got rid of trailing CR's, and fixed up
indentation - probably a consequence of it being developed on Windows),
got rid of the #ifdeffed-out FCS stuff (were we to be able handle
captures with the Ethernet FCS at the end of a frame, that'd be handled
in the Ethernet dissector), merged it with the current CVS version, and
checked it in.
Having a TLV dissection loop might be an interesting future enhancement,
just in case some machine sends a packet with out-of-order, missing, or
extra TLVs.
