Ethereal-dev: Re: [Ethereal-dev] Security bug in packet-quakeworld.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sun, 9 Jun 2002 14:27:31 -0700
On Mon, Jun 10, 2002 at 12:20:35AM +1000, Peter Hawkins wrote:
> The string is tokenized into a static buffer of size 1024 (com_token) by 
> COM_Parse. 
> 
> No adequate bounds checking is performed.

I've checked in a change to make various buffers the same size, which
should close those particular problems (Ethereal doesn't crash on a
capture from the program in question), although the string-handling code
in the Quakeworld dissector might want to be redone at some point.