Ethereal-dev: Re: [Ethereal-dev] unused parameters in wcp, x11, v120 and socks removed

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sat, 13 Apr 2002 15:18:23 -0700
On Thu, Apr 11, 2002 at 02:39:27AM -0700, Guy Harris wrote:
> I'm a bit suspicious that the fact that it works on
> "cur_offset" rather than "offset" may be a bug;

...and rightly so, given that...

> the X11 dissector needs to have its heavy use of global variables
> cleaned up a bit,

...after cleaning that up a bit, and making that routine use the
"offset" argument passed to it, at least one X11 packet is dissected
differently - and the new dissection is correct (and the old one
wasn't).

"packet-x11.c" is now free of unused argument and variable errors.