Wireshark · Ethereal-dev: Re: [Ethereal-dev] missing ucd-snmp-config.h

[Ayamura KIKUCHI <ayamura@xxxxxxxxxxx>]

> > > Some include files derived from ucd-snmp, such as snmp_api.h and so on,
> > > need macro definitions in ucd-snmp-config.h.  For example, the macro
> > > STRUCT_SOCKADDR_HAS_SA_UNION_SA_GENERIC_SA_FAMILY2 should be defined
> > > for IRIX 6.5.

> > OK, so it's a problem only on some platforms (other platforms don't have
> > this problem, which is why it didn't show up when any of us tried it);
> > I've checked your change in.

> We built 0.9.3 with ucd-snmp 4.2.3 on IRIX 6.5 and didn't need this
> patch.

Really?

Compilation errors occur if ucd-snmp-config.h is not included in
packet-snmp.c while building 0.9.3 with ucd-snmp 4.2.3 on IRIX 6.5.15f
with MIPSpro Compilers 7.3.1.3m.

	cc -n32 -DHAVE_CONFIG_H -D_U_="" -I. -I/usr/local/include
	-I./wiretap -O2 -OPT:Olimit=0 -I/usr/local/include/gtk-1.2 \
	-I/usr/local/include/glib-1.2 -I/usr/local/lib/glib/include \
	-w -c packet-snmp.c

	cc-1065 cc: ERROR File = /usr/local/include/ucd-snmp/snmp_api.h, Line = 92
	  A semicolon is expected at this point.
	
	      unsigned short    sa_family;
	                        ^
	cc-1101 cc: ERROR File = /usr/local/include/ucd-snmp/snmp_api.h, Line = 94
	  "sa_union" has already been declared in the current scope.
	
	      char              sa_data[ _UCD_SS_PAD1SIZE ];
	                        ^
	cc-1065 cc: ERROR File = /usr/local/include/ucd-snmp/snmp_api.h, Line = 94
	  A semicolon is expected at this point.
	
	      char              sa_data[ _UCD_SS_PAD1SIZE ];
	                        ^

You should carefully look at various definitions in include files
derived from ucd-snmp.

	#ifdef STRUCT_SOCKADDR_HAS_SA_UNION_SA_GENERIC_SA_FAMILY2
	...
	#ifdef _HAVE_SA_LEN
	...
	#else
	...
	#endif
	...
	#else
	#ifdef STRUCT_SOCKADDR_HAS_SA_LEN
	...
	#else
	...
	#endif
	...
	#endif

-- ayamura
Ayamura KIKUCHI, M.D., Ph.D.