Ethereal-dev: Re: [Ethereal-dev] Unused function parameters: Request for help

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Dr. Uwe Girlich" <Uwe.Girlich@xxxxxxxxxxx>
Date: Wed, 3 Apr 2002 15:34:30 +0200
On Tue, Apr 02, 2002 at 08:48:33AM +0200, Dr. Uwe Girlich wrote:
> On Mon, Apr 01, 2002 at 03:46:37PM -0800, Guy Harris wrote:
> > 	2) if not, whether we'd want to bite the bullet and just change
> > 	   them and all its callers.
> I'm just doing this. packet-rpc.c & packet-rpc.h are ready but I can't check
> them in before changing all callers too (it would break compiling for too long).
Ready!

I just checked in

packet-bootparams.c
packet-hclnfsd.c
packet-klm.c
packet-mount.c
packet-ndmp.c
packet-nfs.c
packet-nisplus.c
packet-nlm.c
packet-pcnfsd.c
packet-portmap.c
packet-rpc.c
packet-rpc.h
packet-rquota.c
packet-rwall.c
packet-spray.c
packet-stat-notify.c
packet-stat.c
packet-ypbind.c
packet-yppasswd.c
packet-ypserv.c

The API of many low-level RPC dissection functions changed (pinfo removed).
Maybe it can be removed even further but I just had to stop here (>200k patch
file was enough).
packet-ndmp.c has many unused variables left but I changed it only so, that
compilation was again possible.
In packet-nfs.c (V4 part) are some places, where an (currently) unused "name"
parameter is used. I marked all occurences with _U_ but I think it can be
removed.

Uwe