Ethereal-dev: [Ethereal-dev] [patch] packet-hclnfsd.c fix

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Mike Frisch <mfrisch@xxxxxxxxxx>
Date: Mon, 1 Apr 2002 14:52:34 -0500
Enclosed is a patch that fixes a decoding bug in packet-hclnfsd.c.

Index: packet-hclnfsd.c
===================================================================
RCS file: /cvsroot/ethereal/packet-hclnfsd.c,v
retrieving revision 1.8
diff -r1.8 packet-hclnfsd.c
232,254c232,233
< 	guint32 ngrpnames, ngrpnames_i;
< 	proto_tree *grptree = NULL;
< 	proto_item *grpitem = NULL;
< 
< 	ngrpnames = tvb_get_ntohl(tvb, offset);
< 	if (tree)
< 	{
< 		grpitem = proto_tree_add_text(tree, tvb, offset, 4, "Groups: %d",
< 			ngrpnames);
< 
< 		if (grpitem)
< 			grptree = proto_item_add_subtree(grpitem, ett_hclnfsd_groups);
< 	}
< 	offset += 4;
< 
< 	if (!grptree)
< 		return offset;
< 
< 	for (ngrpnames_i = 0; ngrpnames_i < ngrpnames ; ngrpnames_i++)
< 		offset = dissect_rpc_string(tvb, pinfo, grptree, 
< 			hf_hclnfsd_grpname, offset, NULL);
< 	
< 	return offset;
---
> 	return dissect_rpc_string(tvb, pinfo, tree, hf_hclnfsd_grpname, offset, 
> 		NULL);